Homec4science

(stable) Fix issue with "Publish/Notify" handling in repositories

Authored by epriestley <git@epriestley.com> on Sep 28 2015, 20:17.

Description

(stable) Fix issue with "Publish/Notify" handling in repositories

Summary:
Fixes T8728. As far as I can tell, I simply got this wrong in D11826. This is not the proper name for the preference.

That change primarily focused on the "spammy junk during import" issue, and the code did get the importing flag right. It looks like my testing in D11827 focused on "during import" and just missed this case.

Test Plan: Grepped for disable-herald. Grepped for herald-disable.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8728

Differential Revision: https://secure.phabricator.com/D14181

Details

Committed
epriestley <git@epriestley.com>Sep 28 2015, 20:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH256fd47f2a6b: (stable) Promote 2015 Week 39
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6d7b78f791f0: (stable) Fix issue with "Publish/Notify" handling in repositories (authored by epriestley <git@epriestley.com>).Sep 28 2015, 20:17