Homec4science

Fix various issues with SSH receivers

Authored by epriestley <git@epriestley.com> on Dec 19 2012, 20:11.

Description

Fix various issues with SSH receivers

Summary:

  • Original command is in SSH_ORIGINAL_COMMAND, not normal argv.
  • Use PhutilShellLexer to parse it.
  • Fix a protocol encoding issue with ConduitSSHWorkflow. I think I'm going to make this protocol accept multiple commands anyway because SSH pipes are crazy expensive to build (even locally, they're ~300ms).

Test Plan: With other changes, successfully executed "arc list --conduit-uri=ssh://localhost:2222".

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T550

Differential Revision: https://secure.phabricator.com/D4232

Details

Committed
epriestley <git@epriestley.com>Dec 19 2012, 20:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe78898970ab6: Implement SSHD glue and Conduit SSH endpoint
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6dd01698732f: Fix various issues with SSH receivers (authored by epriestley <git@epriestley.com>).Dec 19 2012, 20:11