Homec4science

Better enforce uniqueness for email delivery

Authored by epriestley <git@epriestley.com> on Jul 31 2011, 20:54.

Description

Better enforce uniqueness for email delivery

Summary:
@skrul reports receiving multiple copies of notification emails since
@hunterbridges configured some bizarre dystopian email replication factory on
their outbound route. Two fixes:

  • Ensure "To" and "Cc" are unique. Email shouldn't be replicated for "To:

x@y.com, x@y.com" but it's silly that we do this.

  • Remove "To" addresses from "Cc". Email shouldn't be replicated here either,

but we don't really lose anything by accommodating this.

Test Plan:
Sent a mail to the same to/cc, verified I was to'd only and not cc'd when the
mail was delivered.

@hunterbridges, can you apply this patch locally and verify it fixes the issue?
You can test by going to MetaMTA -> Send New Message and sending a message to
yourself as both To and CC.

Reviewed By: skrul
Reviewers: skrul, hunterbridges, jungejason, tuomaspelkonen, aran
CC: aran, skrul, epriestley
Differential Revision: 751

Details

Committed
epriestley <git@epriestley.com>Aug 2 2011, 00:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ceb3d340b2f: Use active project filter as default field value when creating new tasks
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6deddbfc701d: Better enforce uniqueness for email delivery (authored by epriestley <git@epriestley.com>).Aug 2 2011, 00:52