Homec4science

(Redesign) Clean up older "Tile" code

Authored by epriestley <git@epriestley.com> on Jun 4 2014, 00:47.

Description

(Redesign) Clean up older "Tile" code

Summary:
This does some backend cleanup of the tile stuff, and some general cleanup of other application things:

  • Users who haven't customized preferences get a small, specific set of pinned applications: Differential, Maniphest, Diffusion, Audit, Phriction, Projects (and, for administrators, Auth, Config and People).
  • Old tile size methods are replaced with isPinnnedByDefault().
  • Shortened some short descriptions.
  • shouldAppearInLaunchView() replaced by less ambiguous isLaunchable().
  • Added a marker for third-party / extension applications.

Test Plan: Faked away my preferences and viewed the home page, saw a smaller set of default pins.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9358

Details

Committed
epriestley <git@epriestley.com>Jun 4 2014, 00:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8827854ff846: Lightblue Hovercards
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6df1a024137c: (Redesign) Clean up older "Tile" code (authored by epriestley <git@epriestley.com>).Jun 4 2014, 00:47