Homec4science

Don't let users write summaries or test plans which will become ambiguous in…

Authored by epriestley <git@epriestley.com> on Nov 12 2016, 16:04.

Description

Don't let users write summaries or test plans which will become ambiguous in commit messages

Summary:
Ref T11085. To recreate the issue:

  • From the web UI, click "Edit Revision".
  • Write something like this as your "Summary" (i.e., put another field marker, like "Test Plan:", into the summary):

This is a test of the
Test Plan: field to see
if it works.

  • Save changes.

Later, when the summary is amended into a commit message, the parser will see two "Test Plan:" fields and fail to parse the message.

Instead, prevent users from making this edit.

Test Plan: {F1917640}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11085

Differential Revision: https://secure.phabricator.com/D16846

Details

Committed
epriestley <git@epriestley.com>Nov 12 2016, 17:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHde77d5249b64: Fix some remarkup formatting in the Arcanist lint document
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6dfc7e48ae7b: Don't let users write summaries or test plans which will become ambiguous in… (authored by epriestley <git@epriestley.com>).Nov 12 2016, 17:03