Homec4science

Don't create invalid build steps while adding them

Authored by epriestley <git@epriestley.com> on Mar 26 2014, 00:12.

Description

Don't create invalid build steps while adding them

Summary:
Ref T1049. Currently, the "add" dialog lets you select a build step type, but then immediately creates one. If you "cancel" from the edit screen, you end up with an empty (and almost certainly invalid) build step.

Instead, don't create the step until it's valid.

Test Plan: Add Step -> Pick Type -> Add Step -> Cancel no longer creates empty step.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D8605

Details

Committed
epriestley <git@epriestley.com>Mar 26 2014, 00:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd6b937ca2796: Allow external systems to send messages to build targets
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6e3c17e6f9fa: Don't create invalid build steps while adding them (authored by epriestley <git@epriestley.com>).Mar 26 2014, 00:12