Homec4science

Allow `*.search` Conduit API methods to have data bulk-loaded by extensions

Authored by epriestley <git@epriestley.com> on Jul 31 2016, 17:19.

Description

Allow *.search Conduit API methods to have data bulk-loaded by extensions

Summary:
Ref T11404. Currently, SearchEngineAttachments can bulk-load data but SearchEngineExtensions can not.

This leads to poor performance of custom fields. See T11404 for discussion.

This changes the API to support a bulk load + format pattern like the one Attachments use. The next change will use it to bulk-load custom field data.

Test Plan:

  • Ran differential.query, differential.revision.search as a sanity check.
  • No behavioral changes are expected
  • See next revision.

Reviewers: yelirekim, chad

Reviewed By: chad

Maniphest Tasks: T11404

Differential Revision: https://secure.phabricator.com/D16350

Details

Committed
epriestley <git@epriestley.com>Jul 31 2016, 20:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH33fca12816b6: Pick some preset build statuses
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6e57582aff82: Allow `*.search` Conduit API methods to have data bulk-loaded by extensions (authored by epriestley <git@epriestley.com>).Jul 31 2016, 20:15