Homec4science

Don't reveal oauth application token information

Authored by epriestley <epriestley@phabricator.com> on Apr 14 2011, 21:20.

Description

Don't reveal oauth application token information

Summary:
There's an OAuth diagnostics page at /oauth/facebook/diagnose/, which
shows some diagnostic information. Currently, it attempts to establish an
application token session and shows the token if it is successful. An attacker
could use this to do vaguely nefarious things (retreive application statistics,
I think?).

This interface was originally admin-only but then I threw out the very silly
admin mode patch I had at the time and we currently have no admin mode, and
thus this interface is public. This token isn't useful in diagnosis anyway,
so don't reveal it.

Test Plan:
Visited oauth diagnostics page, no token revealed

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason
CC: tuomaspelkonen
Differential Revision: 136

Details

Committed
epriestley <epriestley@phabricator.com>Apr 14 2011, 22:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHca7a0de1cf77: Prevent a race in Phabricator workers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <epriestley@phabricator.com> committed rPH6e713ad78474: Don't reveal oauth application token information (authored by epriestley <epriestley@phabricator.com>).Apr 14 2011, 22:32