Homec4science

Use %B when writing to Harbormaster build logs

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Jan 29 2015, 00:06.

Description

Use %B when writing to Harbormaster build logs

Summary: Fixes T7007. Using %B permits non-UTF8 data to be appended to Harbormaster build logs. Since we're not really in control of the processes Harbormaster is running remotely, and since they may output invalid UTF8 data, we should store the invalid data instead of failing the build (due to UTF8 exception).

Test Plan: @epriestley said this was the right fix, though I haven't tested it on our production system which actually exhibits the issue yet.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7007

Differential Revision: https://secure.phabricator.com/D11532

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Jan 29 2015, 00:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8798083ad909: Proxy VCS SSH requests
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPH6e723c5c5aef: Use %B when writing to Harbormaster build logs (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Jan 29 2015, 00:06