Homec4science

Fix a dashboard bucketing bug

Authored by epriestley <git@epriestley.com> on May 16 2016, 20:02.

Description

Fix a dashboard bucketing bug

Summary: Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's (string) !== (int). Just use != so this will still work if we turn it into a real string in the future.

Test Plan: Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15928

Details

Committed
epriestley <git@epriestley.com>May 16 2016, 20:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8a98868bfbc4: Remove "days fresh" / "days stale" indictator in Differential revision list
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6e9828c743a7: Fix a dashboard bucketing bug (authored by epriestley <git@epriestley.com>).May 16 2016, 20:07