Homec4science

Add a 'silent' option to differential.createcomment

Authored by epriestley <git@epriestley.com> on Aug 20 2012, 23:08.

Description

Add a 'silent' option to differential.createcomment

Summary: See T1677. I think wanting bots to be able to post comments without sending email is a pretty reasonable use case. Eventually we should probably support this more broadly and maybe protect it with permissions (normal users maybe shouldn't be able to do this?) but we can wait for use cases.

Test Plan: Made comments with and without "silent". Verified that the non-silent comment sent email, and the silent comment did not.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1677

Differential Revision: https://secure.phabricator.com/D3341

Details

Committed
epriestley <git@epriestley.com>Aug 20 2012, 23:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH21ebd1a609e2: Fix an issue with To/CC placeholders
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH6ed202b6756e: Add a 'silent' option to differential.createcomment (authored by epriestley <git@epriestley.com>).Aug 20 2012, 23:08