Homec4science

Change background for image views in Differential

Authored by Alan Huang <alanh@fb.com> on Aug 14 2012, 02:21.

Description

Change background for image views in Differential

Summary:
Many images in Differential changesets are icons designed for
use on dark backgrounds. This makes them invisible on Differential's
white background. This adds an option to use a darker background
instead so you can see the images.

Currently this behavior is triggered on hover. (Also, it's a rather
garish fuchsia.) It seems fine UX-wise but I'm not totally sure of it.

Test Plan:
Load diff containing grippy_texture. Marvel at the grippy
fuchsia.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3272

Details

Committed
Alan Huang <alanh@fb.com>Aug 14 2012, 02:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6f3d15bb8277: Remove hard-coded tests against 'phabricator' namespace in setup
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPH6fc01aa5fda5: Change background for image views in Differential (authored by Alan Huang <alanh@fb.com>).Aug 14 2012, 02:21