Homec4science

Disable the edit/quote menu for non-standard comments

Authored by epriestley <git@epriestley.com> on May 19 2014, 21:39.

Description

Disable the edit/quote menu for non-standard comments

Summary: Fixes T4930. We currently show the edit/quote menu if a transaction group has inline comments, but this doesn't make sense and doesn't work properly. Only show this menu if the group has a normal comment.

Test Plan:
Viewed these groups:

  • Normal comment (edits fine).
  • Just inlines (no more edit menu).
  • Inline + comment (edits fine, affects the normal comment properly).

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: bitglue, epriestley

Maniphest Tasks: T4930

Differential Revision: https://secure.phabricator.com/D9180

Details

Committed
epriestley <git@epriestley.com>May 19 2014, 21:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb64407d47e18: Fix explosive runtime of detectCopiedCode()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH703e0b396888: Disable the edit/quote menu for non-standard comments (authored by epriestley <git@epriestley.com>).May 19 2014, 21:39