Homec4science

Adding 'Secure Browsing' config setting to Facebook OAuth.

Authored by Neal Poole <neal@fb.com> on Jul 18 2012, 03:18.

Description

Adding 'Secure Browsing' config setting to Facebook OAuth.

Summary: The Graph API exposes a new field, security_settings, which allows applications to see whether a user has enabled Secure Browsing. This diff adds a configuration setting to Phabricator which forces users to have Secure Browsing enabled when logging in via Facebook.

Test Plan: With the configuration setting off, verify that secure browsing does not affect the ability to log in. With the configuration setting on and secure browsing off, verify that the login attempts is rejected. Then verify that the login attempt succeeds when secure browsing is enabled.

Reviewers: epriestley

Reviewed By: epriestley

CC: arice, aran, Korvin

Maniphest Tasks: T1487

Differential Revision: https://secure.phabricator.com/D2964

Details

Committed
Neal Poole <neal@fb.com>Jul 18 2012, 03:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0d162e15f649: Make Diffusion view sticky
Branches
Unknown
Tags
Unknown

Event Timeline

Neal Poole <neal@fb.com> committed rPH7081923bd73c: Adding 'Secure Browsing' config setting to Facebook OAuth. (authored by Neal Poole <neal@fb.com>).Jul 18 2012, 03:18