Homec4science

Revert D4359 and apply a better fix

Authored by epriestley <git@epriestley.com> on Jan 22 2013, 21:26.

Description

Revert D4359 and apply a better fix

Summary:
In D4359 I fixed an error with 'lint' in SVN repositories, but created an error with the 'lint' column in Javascript. Specifically, when we load the column information over Ajax, we now always include a 'lint' key, even if there is no lint column.

Instead, access the 'lint' property conditionally (so SVN works) but don't include the key if there's no data (so Javascript works).

Test Plan: Loaded SVN, non-SVN non-lint, non-SVN+lint repositories. Everything appeared to work correctly.

Reviewers: asherkin, codeblock

Reviewed By: codeblock

CC: aran

Differential Revision: https://secure.phabricator.com/D4578

Details

Committed
epriestley <git@epriestley.com>Jan 22 2013, 21:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPH35d73414f818: Remove legacy support for 'phd repository-launch' and 'phd repository-launch…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH70a2a653ff23: Revert D4359 and apply a better fix (authored by epriestley <git@epriestley.com>).Jan 22 2013, 21:26