Homec4science

Allow packages to be added as revision reviewers via the UI

Authored by epriestley <git@epriestley.com> on May 13 2016, 19:51.

Description

Allow packages to be added as revision reviewers via the UI

Summary:
Ref T10939. This lets you add packages as reviewers manually.

"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.

Test Plan:

  • Added a package as a reviewer manually.
  • Joined it, got authority over it.
  • Saw the review on my dashboard.
  • Accepted the revision, got authority extended to the package review.

{F1311652}

{F1311653}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15914

Details

Committed
epriestley <git@epriestley.com>May 14 2016, 02:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4ba4cb971178: Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH70ddb1c45fe4: Allow packages to be added as revision reviewers via the UI (authored by epriestley <git@epriestley.com>).May 14 2016, 02:20