Store revision reviewer state as edges
70fd3dd54f56
Actions

Authored by Juan Pablo Civile <elementohb@gmail.com> on Jul 10 2013, 22:45.

Description

Store revision reviewer state as edges

Summary:
Keep track of the state of a reviewer in an edge between reviewer and revision.
The edge stores the state of the review, added or rejected. And if the revision was
accepted by that reviewer the id of the diff accepted.

Test Plan:
Create diffs and clowncopterize reviewer list changes. This includes:

Adding new reviewers
Resigning
Commandering a revision

Reviewers: epriestley

CC: aran, Korvin

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D6372

Conflicts:
src/applications/differential/editor/DifferentialCommentEditor.php

Details

Committed

epriestley <git@epriestley.com>

Jul 10 2013, 22:50

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHc05e026e656a: Detect and warn about APC 3.1.14 / 3.1.15

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH70fd3dd54f56: Store revision reviewer state as edges (authored by Juan Pablo Civile <elementohb@gmail.com>).Jul 10 2013, 22:50

Changes (6)

				Path
	M			src/__celerity_resource_map__.php
	M			src/__phutil_library_map__.php
	A			src/applications/differential/constants/DifferentialReviewerStatus.php
	M			src/applications/differential/editor/DifferentialCommentEditor.php
	M			src/applications/differential/editor/DifferentialRevisionEditor.php
	M			src/infrastructure/edges/constants/PhabricatorEdgeConfig.php