Homec4science

Use Conduit in PhabricatorRepositoryGitCommitChangeParserWorker

Authored by June Rhodes <jrhodes@redpointsoftware.com.au> on Apr 8 2016, 22:08.

Description

Use Conduit in PhabricatorRepositoryGitCommitChangeParserWorker

Summary:
Ref T2783. This allows this worker to run on a machine different to the one that stores the repository, by routing the execution of Git over Conduit calls.

This API method is super gross, but fixing it isn't straightforward and it runs into other complicated considerations. We can fix it later; for now, just define it as "internal" to limit how much mess this creates.

"Internal" methods do not appear on the console.

Test Plan: Ran bin/repository reparse --change <commit> --trace on several commits, saw daemons make a Conduit call instead of running a git command.

Reviewers: hach-que, chad

Reviewed By: chad

Subscribers: joshuaspence, Korvin, epriestley

Maniphest Tasks: T2783

Differential Revision: https://secure.phabricator.com/D11874

Details

Committed
epriestley <git@epriestley.com>Apr 14 2016, 13:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0379cc10acbd: Fixes T10805. When clustering is not configured, this check should just return.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7150aa8e192e: Use Conduit in PhabricatorRepositoryGitCommitChangeParserWorker (authored by June Rhodes <jrhodes@redpointsoftware.com.au>).Apr 14 2016, 13:53