Homec4science

Fully modularize Herald field values

Authored by epriestley <git@epriestley.com> on Jul 16 2015, 23:12.

Description

Fully modularize Herald field values

Summary: Ref T8726. This gets rid of all the VALUE_* constants and lets Fields provide arbitrary typeaheads without upstream/JS changes.

Test Plan: Used all tokenizers. Used "Another Herald Rule". Grepped for all removed constants.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13616

Details

Committed
epriestley <git@epriestley.com>Jul 16 2015, 23:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHed3dfd491f17: Further modularize Herald values
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH715233fb6115: Fully modularize Herald field values (authored by epriestley <git@epriestley.com>).Jul 16 2015, 23:12