Homec4science

fixes two small diffusion bugs

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 3 2012, 18:27.

Description

fixes two small diffusion bugs

Summary: make sure we only print the fancy tool tip thing if we have all the data we need. (fixes T2136). additionally, default $branches to array() to prevent errors from reset on null.

Test Plan: made a checkin for a mercurial repo with user "foo@bar" with no branch. verified name showed up in all views. also noted on commit detail view there was no more error about reset() on null for $branches.

Reviewers: epriestley

Reviewed By: epriestley

CC: chad, aran, Korvin

Maniphest Tasks: T2136

Differential Revision: https://secure.phabricator.com/D4065

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Dec 3 2012, 18:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2b6935351987: Fix a bug with T1643
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH7154bea03c2c: fixes two small diffusion bugs (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 3 2012, 18:27