Homec4science

Discard stdout/stderr from the aphlict subprocess when running in daemon…

Authored by epriestley <git@epriestley.com> on Nov 14 2016, 01:38.

Description

Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode

Summary:
Fixes T11818. We don't discard output, so once we read more than 2GB of output we'll exceed the maximum size of a string in an internal buffer.

Instead, configure the future so output is discarded.

Test Plan: Added logging to libphutil/, saw internal buffer grow steadily before this change and stay constant at 0 after this change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11818

Differential Revision: https://secure.phabricator.com/D16855

Details

Committed
epriestley <git@epriestley.com>Nov 14 2016, 01:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH19c6ccb27987: Allow bin/aphlict to start without a valid database connection
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7165e4da90a1: Discard stdout/stderr from the aphlict subprocess when running in daemon… (authored by epriestley <git@epriestley.com>).Nov 14 2016, 01:43