Homec4science

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Authored by epriestley <git@epriestley.com> on Apr 19 2014, 02:52.

Description

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Summary: This %d should be a %s, since the PhutilNumber value may get formatted according to locale settings.

Test Plan: will make @zeeg

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8814

Details

Committed
epriestley <git@epriestley.com>Apr 19 2014, 02:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9889892e5b76: Actually squelch Harbormaster "test passed" mail
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH71ef48b3e519: When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines" (authored by epriestley <git@epriestley.com>).Apr 19 2014, 02:52