Homec4science

Only let users log in to an OAuth server if they can see it

Authored by epriestley <git@epriestley.com> on Feb 5 2015, 19:57.

Description

Only let users log in to an OAuth server if they can see it

Summary:
Fixes T7169. We just weren't doing a policy-aware query. Basic idea here is that if you set an app to be visible only to specific users, those specific users are the only ones who should be able to authorize it.

In the Phacility cluster, this allows us to prevent users who haven't been invited from logging in to an instance.

Test Plan:

  • Tried to log into an instance I was not a member of.
  • Logged into an instance I am a member of.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7169

Differential Revision: https://secure.phabricator.com/D11696

Details

Committed
epriestley <git@epriestley.com>Feb 5 2015, 19:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdca27279cc55: README update - rely on bug reporting doc and add section about community chat
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7213eb01e030: Only let users log in to an OAuth server if they can see it (authored by epriestley <git@epriestley.com>).Feb 5 2015, 19:57