Homec4science

Pull only existing authorPHIDs in blame

Authored by Jakub Vrana <jakub@vrana.cz> on Apr 19 2013, 05:20.

Description

Pull only existing authorPHIDs in blame

Summary:
I've hit this error by exhausting memory limit on blaming a big file with lots of unknown authors.
It triggered the error ~1000 times with stack trace containing the whole ~100 kB file.
The memory ran out when it tried to JSON serialize the stack traces for the DarkConsole.

Test Plan: Blamed file with unknown authors.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5730

Details

Committed
Jakub Vrana <jakub@vrana.cz>Apr 19 2013, 05:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd2874a96b8ef: DERP 2 with my last diff - shouldn't have pulled this outside the conditional
Branches
Unknown
Tags
Unknown

Event Timeline

Jakub Vrana <jakub@vrana.cz> committed rPH725373386afa: Pull only existing authorPHIDs in blame (authored by Jakub Vrana <jakub@vrana.cz>).Apr 19 2013, 05:20