Homec4science

Add an "Accepted Differential revision" field to Commit and pre-commit Content…

Authored by epriestley <git@epriestley.com> on Dec 20 2013, 21:39.

Description

Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules

Summary: Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an accepted revision"; allow that.

Test Plan: Pushed commits into a rule with this field, saw it work / not crash.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, mbishopim3

Maniphest Tasks: T3936, T4195

Differential Revision: https://secure.phabricator.com/D7807

Details

Committed
epriestley <git@epriestley.com>Dec 20 2013, 21:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2436458b903c: Implement "Differential Revision" fields in Herald pre-commit content adapter
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH72c73d644b0e: Add an "Accepted Differential revision" field to Commit and pre-commit Content… (authored by epriestley <git@epriestley.com>).Dec 20 2013, 21:39