Homec4science

Improve task subpriority movement algorithm for homogenous blocks

Authored by epriestley <git@epriestley.com> on Mar 26 2015, 19:11.

Description

Improve task subpriority movement algorithm for homogenous blocks

Summary:
Fixes T7664. When there are a large number of tasks (400+) with the same subpriority (which can happen if the subpriority features are rarely used), it may take more than 30 seconds to rebalance them.

Make the algorithm more aggressive about rebalancing homogenous blocks of tasks.

This may need to get even fancier, but I'd guess it can process blocks 1-2 orders of magnitude larger, which should be ~all installs.

(If someone still hits issues with this, I'll make it fancier.)

Once a block is rebalanced, it doesn't need to be rebalanced again (at least, not as a whole block) so we basically just need to get over the initial hurdle here and then we're good.

In the worst case, we can provide bin/maniphest rebalance or similar and do the rebalance step offline.

And, in any case, we have more test coverage here now.

Test Plan:

  • Existing tests.
  • New tests.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7664

Differential Revision: https://secure.phabricator.com/D12166

Details

Committed
epriestley <git@epriestley.com>Mar 26 2015, 19:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4bdc51237a26: Add ability to have tooltips on buttons
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH731404445fe8: Improve task subpriority movement algorithm for homogenous blocks (authored by epriestley <git@epriestley.com>).Mar 26 2015, 19:11