Homec4science

Send old login code to the bottom of the sea

Authored by epriestley <git@epriestley.com> on Jun 19 2013, 10:33.

Description

Send old login code to the bottom of the sea

Summary:
Ref T1536. This is extremely reachable and changes the login code to the new stuff.

Notes:

  • I've hard-disabled password registration since I want installs to explicitly flip it on via config if they want it. New installs will get it by default in the future, but old installs shouldn't have their auth options change.
  • Google doesn't let us change the redirect URI, so keep the old one working.
  • We need to keep a bit of LDAP around for now for LDAP import.
  • Facebook: This causes substantive changes in what login code is executed.

Test Plan:

  • Logged in / logged out / registered, hit new flows.
  • Logged in with google.
  • Verified no password registration by default.

Reviewers: btrahan, chad

Reviewed By: chad

CC: wez, nh, aran, mbishopim3

Maniphest Tasks: T1536

Differential Revision: https://secure.phabricator.com/D6222

Details

Committed
epriestley <git@epriestley.com>Jun 19 2013, 10:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8c8ab25fa1aa: Restore/respect "require secure browsing" for Facebook (phabricator)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH73c2c1d2e60f: Send old login code to the bottom of the sea (authored by epriestley <git@epriestley.com>).Jun 19 2013, 10:33