Homec4science

Modernize file embed Remarkup rule

Authored by epriestley <git@epriestley.com> on Oct 2 2013, 03:03.

Description

Modernize file embed Remarkup rule

Summary: Ref T603. Make this rule properly policy-aware, and extend from PhabricatorRemarkupRuleObject.

Test Plan:

  • Embedded an image, tested all options (name, link, float, layout, size).
  • Used lightbox to view several images.
  • Embedded a text file, tested all options (name).
  • Embedded audio, tested all options (loop, autoplay).
  • Attached a file via comment to a task, verified edge was created.
  • Attached a file via comment to a conpherence, verified edge was created.
  • Viewed old files, verified remarkup version bump rendered them correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7192

Details

Committed
epriestley <git@epriestley.com>Oct 2 2013, 03:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaac490180f30: Write "attach" edges when files are attached to objects via comment or other…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH742d45b625d1: Modernize file embed Remarkup rule (authored by epriestley <git@epriestley.com>).Oct 2 2013, 03:03