Homec4science

Make Application->isInstalled canonical

Authored by Edward Speyer <edward@fb.com> on Mar 12 2013, 12:33.

Description

Make Application->isInstalled canonical

Summary: We currently inspect phabricator.uninstalled-applications in two places -- when building a list of getAllInstalledApplications() and when asking an application if it isInstalled(). This diff moves that all to the latter function, meaning we can override it in clever and subtle ways for applications that want to add extra defensiveness about whether they should be considered installed or not (e.g. Releeph, in D4932.)

Test Plan: Load the main Phabricator page, pick an application, uninstall it, notice it is absent, then install it and notice the launch icon reappear.

Reviewers: epriestley, Afaque_Hussain

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5326

Details

Committed
Edward Speyer <edward@fb.com>Mar 13 2013, 17:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH33997d43d0ea: Fix undefined index in ManiphestTaskSummaryView
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPH7487c5740178: Make Application->isInstalled canonical (authored by Edward Speyer <edward@fb.com>).Mar 13 2013, 17:01