Homec4science

(stable) Respect user/pass flags to bin/storage for direct DatabaseRef-based…

Authored by epriestley <git@epriestley.com> on Nov 19 2016, 17:35.

Description

(stable) Respect user/pass flags to bin/storage for direct DatabaseRef-based queries

Summary:
Ref T11893. Previously, we excuted all bin/storage queries through StorageManagementAPI objects.

After D16848, we execute some queries through PhabricatorDatabaseRef. However, the refs we use weren't getting passed the -u / -p flags correctly, for specifying alternate administrative credentials.

Test Plan:

  • Created a second account (trunk).
  • Ran bin/storage -u trunk.
  • Made libphutil throw when not connecting as that user.
  • Before patch: some connections incorrectly used the default user, "root".
  • After patch: all connections correctly used the configured user, "trunk".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11893

Differential Revision: https://secure.phabricator.com/D16901

Details

Committed
epriestley <git@epriestley.com>Nov 19 2016, 17:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH10c4dedd1830: (stable) Promote 2016 Week 47
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH74a0e5cd7930: (stable) Respect user/pass flags to bin/storage for direct DatabaseRef-based… (authored by epriestley <git@epriestley.com>).Nov 19 2016, 17:39