Provide better parsing primitives for hunks
74a4c2cf0b1b
Actions

Authored by epriestley <git@epriestley.com> on Mar 24 2015, 21:11.

Description

Provide better parsing primitives for hunks

Summary:
Ref T1266. This prepares to fix case (2) on T1266 by improving the robustness of hunk parsing.

In particular, the copy detection code abuses this API because it isn't currently expressive or flexible enough.

Make it more flexible and cover it exhaustively.

I'll move callsites to the new stuff in upcoming revisions.

Test Plan: Unit tests.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1266

Committed

epriestley <git@epriestley.com>

Mar 24 2015, 21:11

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH74a4c2cf0b1b: Provide better parsing primitives for hunks (authored by epriestley <git@epriestley.com>).Mar 24 2015, 21:11

				Path
	M			src/applications/differential/storage/DifferentialHunk.php
	M			src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
	A			src/applications/differential/storage/__tests__/hunk/fruit1.diff
	A			src/applications/differential/storage/__tests__/hunk/fruit2.diff
	A			src/applications/differential/storage/__tests__/hunk/offset.diff
	A			src/applications/differential/storage/__tests__/hunk/trailing_newline_absent.diff
	A			src/applications/differential/storage/__tests__/hunk/trailing_newline_added.diff
	A			src/applications/differential/storage/__tests__/hunk/trailing_newline_removed.diff