Homec4science

Remarkup: Correctly render inline embed layout

Authored by epriestley <git@epriestley.com> on Feb 9 2015, 16:52.

Description

Remarkup: Correctly render inline embed layout

Summary:
The generated HTML is like <p>some text <div …>…</div> more text</p>, and HTML <p/> tags may not contain block content like <div/> tags. Browsers actually parse this as if it was <p>some text </p><div …>…</div> more text<p></p> (sic).

The layout CSS class already has display: inline set, but this is not sufficient. Browser's HTML parser doesn't care what CSS rules will be applied, it only deals with the meanings of tags.

Fixes T7201.

Test Plan:
Verify that the following displays the image inline:

some text {Fnnn,layout=inline} more text

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Projects: #remarkup

Maniphest Tasks: T7201

Differential Revision: https://secure.phabricator.com/D11706

Details

Committed
epriestley <git@epriestley.com>Feb 9 2015, 16:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfce178caf22f: Add bigtext option to PHUIActionPanelView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH74b860519d8a: Remarkup: Correctly render inline embed layout (authored by epriestley <git@epriestley.com>).Feb 9 2015, 16:52