Homec4science

Add sanity to DifferentialRevisionQuery

Authored by Nick Harper <nharper@fb.com> on Dec 6 2011, 23:21.

Description

Add sanity to DifferentialRevisionQuery

Summary:
Changed cc/reviewer search to be a union/or instead of intersection/and within
each list. Also added support to search for multiple authors (same behavior as
cc/reviewer), and updated conduit call to match. (See discussion on D1158.)

Test Plan:
Used the conduit call to search for revisions with one of 2 people on the cc
list, and checked the results to see that it wasn't constraining to requiring
both be on the cc list.

Reviewers: epriestley, jungejason, btrahan

Reviewed By: epriestley

CC: aran, nh, epriestley

Differential Revision: 1179

Details

Committed
Nick Harper <nharper@fb.com>Dec 6 2011, 23:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH55ff8c582940: Improve documentation around creating extension libraries for Phabricator
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH74f710a437e7: Add sanity to DifferentialRevisionQuery (authored by Nick Harper <nharper@fb.com>).Dec 6 2011, 23:47