Homec4science
Diffusion Phabricator 74faacee4d4a

Never try to run README as a commit hook
74faacee4d4a
Actions

Authored by epriestley <git@epriestley.com> on May 5 2014, 19:54.

Description

Never try to run README as a commit hook

Summary:
Fixes T4960. Users chmod +x this, and then bash chokes on it.

Phabricator "owns" this file anyway, so there is no real ambiguity here: this should never be a hook script.

Test Plan:

  • Did chmod +x README.
  • Made a commit.
  • Added z.sh, got blocked.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T4960

Differential Revision: https://secure.phabricator.com/D8981

Details

Committed
epriestley <git@epriestley.com>May 5 2014, 19:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPHac9c82fcdf03: Check view policy, not join policy, when raising an error for Phame custom…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH74faacee4d4a: Never try to run README as a commit hook (authored by epriestley <git@epriestley.com>).May 5 2014, 19:54

Changes (1)

Path
Msrc/applications/diffusion/engine/DiffusionCommitHookEngine.php

rPH74faacee4d4a

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
c4science · Help