Homec4science

Hide the autocompleter intelligently when you ignore it and keep typing

Authored by epriestley <git@epriestley.com> on Jan 16 2016, 23:33.

Description

Hide the autocompleter intelligently when you ignore it and keep typing

Summary:
Ref T10163. When we think the user has finished typing a word (because they typed a space, period, or other similar characters) and nothing else they might type could possibly change the outcome (usually because the words they have typed already match nothing), just deactivate the autocomplete.

As a special case, if the word they have typed already select exactly one result, and they have already typed exactly that result, assume they just typed it from memory and deactivate.

Test Plan:

  • Typed @dog qwer zxcv and saw autocomplete deactivate on the space before z (on my local install, @dog is ambiguous but @dog qwer matches nothing).
  • Typed @epriestley and saw autocomplete deactivate on space.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10163

Differential Revision: https://secure.phabricator.com/D15039

Details

Committed
epriestley <git@epriestley.com>Jan 16 2016, 23:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPH849b4c765a1f: When the autocompleter would fall off the bottom of the screen, put it above…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH75b8d3312bbb: Hide the autocompleter intelligently when you ignore it and keep typing (authored by epriestley <git@epriestley.com>).Jan 16 2016, 23:41