Homec4science

Don't prefill "add email address" from GET

Authored by epriestley <git@epriestley.com> on Mar 11 2014, 00:21.

Description

Don't prefill "add email address" from GET

Summary: Via HackerOne. I don't think this is a security vulnerability, but it is inconsistent. There's no reason to prefill this, and I think the code was just lazy.

Test Plan:

  • Hit this page with ?email=xyz in a GET request, no more prefill.
  • Looped the page with bad addresses, appropriate prefill.
  • Added an address.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8458

Details

Committed
epriestley <git@epriestley.com>Mar 11 2014, 00:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH042ab0ad9d03: Fix three minor edge case behaviors in Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH761b66228371: Don't prefill "add email address" from GET (authored by epriestley <git@epriestley.com>).Mar 11 2014, 00:21