Homec4science

Reduce responsibilities of PhabricatorPasteSearchEngine->buildSearchForm()

Authored by epriestley <git@epriestley.com> on May 27 2013, 22:43.

Description

Reduce responsibilities of PhabricatorPasteSearchEngine->buildSearchForm()

Summary:
Ref T2625. The specialized buildSearchForm() method has significant amounts of generic form construction responsibility right now. Lift the generic stuff above the Engine level. Also:

  • Rename "users" to "authors".
  • Use "users", not "searchowners" (which incorrectly includes "upforgrabs").
  • No need for "set_" prefixes anymore since we do GET redirects with query keys.
  • Use newer style for search stuff.

Test Plan:
Searched for stuff?

{F44342}

Reviewers: btrahan, blc

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2625

Differential Revision: https://secure.phabricator.com/D6061

Details

Committed
epriestley <git@epriestley.com>May 27 2013, 22:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa67b1f950c84: Make query results page slightly more generic
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH764e4574d11a: Reduce responsibilities of PhabricatorPasteSearchEngine->buildSearchForm() (authored by epriestley <git@epriestley.com>).May 27 2013, 22:43