Homec4science

Extract textual object list parsing from Differential

Authored by epriestley <git@epriestley.com> on Mar 8 2014, 02:44.

Description

Extract textual object list parsing from Differential

Summary:
Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.

Test Plan:

  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8445

Details

Committed
epriestley <git@epriestley.com>Mar 8 2014, 02:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaff34077c52c: Move Differential commit message parsing to a separate, tested class
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH76577df50614: Extract textual object list parsing from Differential (authored by epriestley <git@epriestley.com>).Mar 8 2014, 02:44