Homec4science

Hold a lock while collecting garbage

Authored by epriestley <git@epriestley.com> on Oct 20 2016, 20:36.

Description

Hold a lock while collecting garbage

Summary:
Fixes T11771. Adds a lock around each GC process so we don't try to, e.g., delete old files on two machines at once just because they're both running trigger daemons.

The other aspects of this daemon (actual triggers; nuance importers) already have separate locks.

Test Plan: Ran bin/phd debug trigger --trace, saw daemon acquire locks and collect garbage.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11771

Differential Revision: https://secure.phabricator.com/D16739

Details

Committed
epriestley <git@epriestley.com>Oct 20 2016, 22:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH272046ae7701: Write a basic SSH pull log for Git
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7678f412be22: Hold a lock while collecting garbage (authored by epriestley <git@epriestley.com>).Oct 20 2016, 22:40