Homec4science

Fix error in `PhabricatorSetupIssueView`

Authored by Ricky Elrod <ricky@elrod.me> on Jan 12 2013, 00:28.

Description

Fix error in PhabricatorSetupIssueView

Summary:

  • Move prettyPrintJSON() and make it static.
  • Use it from PhabricatorSetupIssueView
  • Update other config/ places that use it to call it from the new class.

This fixes a bug in PhabricatorSetupIssueView which showed up if the value
was an array and couldn't be rendered by phutil_escape_html().

Test Plan:

  • Rendered some config options.
  • Went to /config/issue/config.unknown.phame.skins/ without error.

Reviewers: epriestley, btrahan, chad

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2255

Differential Revision: https://secure.phabricator.com/D4411

Details

Committed
epriestley <git@epriestley.com>Jan 12 2013, 00:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH08687c0b172d: Search options.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH76c10f497fc8: Fix error in `PhabricatorSetupIssueView` (authored by Ricky Elrod <ricky@elrod.me>).Jan 12 2013, 00:28