Homec4science

Reduce laziness for "Mark Committed"

Authored by epriestley <git@epriestley.com> on Mar 7 2012, 19:20.

Description

Reduce laziness for "Mark Committed"

Summary:

  • Enforce proper workflow rules.
  • Fix a derp-bug with patches.

Test Plan:

  • Tried to mark a revision I didn't own.
  • Tried to mark a revision already marked committed.
  • Tried to mark a revision otherwise not accepted.
  • Verified daemon can override workflow rules and mark from arbitrary states.

Reviewers: btrahan, Makinde

Reviewed By: Makinde

CC: aran, epriestley

Maniphest Tasks: T948

Differential Revision: https://secure.phabricator.com/D1809

Details

Committed
epriestley <git@epriestley.com>Mar 7 2012, 19:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH62f18914db11: Add "mark committed" action to the web UI
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH76fd9a2d2832: Reduce laziness for "Mark Committed" (authored by epriestley <git@epriestley.com>).Mar 7 2012, 19:20