Homec4science

Fix confusing ordering of similar actions in transaction groups

Authored by epriestley <git@epriestley.com> on Dec 5 2015, 19:05.

Description

Fix confusing ordering of similar actions in transaction groups

Summary:
Fixes T7250. Currently, if a display group of transactions (multiple transactions by the same author in a short period of time with no intervening comments) has several transactions of similar strength (e.g., several status change transactions) we can end up displaying them in reverse chronological order, which is confusing.

Instead, make sure transactions of the same type/strength are always in logical order.

Test Plan:

  • Merged a task into another task, then reopened the merged task.
  • Before patch: merge/reopen showed in wrong order.

{F1014954}

  • After patch: merge/reopen show in correct order.

{F1014955}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7250

Differential Revision: https://secure.phabricator.com/D14680

Details

Committed
epriestley <git@epriestley.com>Dec 5 2015, 19:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0ce373a01267: Add subscriber mailtag to blog posts
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH77d33ec7beda: Fix confusing ordering of similar actions in transaction groups (authored by epriestley <git@epriestley.com>).Dec 5 2015, 19:51