Homec4science

Policy - fix up DifferentialChangesetParser

Authored by Bob Trahan <btrahan@phacility.com> on Jan 30 2015, 20:17.

Description

Policy - fix up DifferentialChangesetParser

Summary:
Ref T7094. We should do a policy query on the files IMO because there exists a scenario where the file gets locked down directly. This requires being a bit more disciplined about setting user, which in turn requires deciding whether or not to show edit / reply links as a separate piece of logic, not conditional on user presence.

This is not the best code but I don't think it gets worse with this and is just some other nuance in any larger cleanup we take on someday.

Test Plan: looked at a revision and noted inline comments rendered correctly with reply / edit actions. looked at a diff standalone and noted no reply / edit actions as expected. looked at a "details" link on a transaction and it rendered correctly. looked at a diff in phriction of page edits and it looked good. grepped around and verified the remaining callsite in diffusion already has the setUser call.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7094

Differential Revision: https://secure.phabricator.com/D11579

Details

Committed
Bob Trahan <btrahan@phacility.com>Jan 30 2015, 20:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2fc43598b5a3: Differential - add ability to setup "create" addresses for revisions
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH77eae81e1a5c: Policy - fix up DifferentialChangesetParser (authored by Bob Trahan <btrahan@phacility.com>).Jan 30 2015, 20:17