Homec4science

Resolve link framing issue for public feed

Authored by epriestley <git@epriestley.com> on Jan 30 2012, 13:12.

Description

Resolve link framing issue for public feed

Summary:

  • Use $this->linkTo($phid) to render all links.
  • Simplify code.

Test Plan: Public feed renders with 'target="_top"' links. Nonpublic feed
doesn't. Looked at a bunch of feed stories, none seem broken.

Reviewers: btrahan, aran, nh, jungejason, ide

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T453

Differential Revision: https://secure.phabricator.com/D1514

Details

Committed
epriestley <git@epriestley.com>Jan 30 2012, 13:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5755830faa0e: Make Differential comments be styled similarly to Maniphest comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH780397aa7176: Resolve link framing issue for public feed (authored by epriestley <git@epriestley.com>).Jan 30 2012, 13:12