Homec4science

Make id/phid Conpherence stuff more consistent

Authored by epriestley <git@epriestley.com> on Apr 1 2013, 21:44.

Description

Make id/phid Conpherence stuff more consistent

Summary:
Currently, selected_conpherence_id is actually a PHID. Instead, use ids everywhere.

Also, use replaceState instead of pushState. This means "back" takes you out of conpherence (not back to the last thread you looked at) but I think that's more consistent with user expectation.

Test Plan: Loaded thread list, loaded specific thread.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5503

Details

Committed
epriestley <git@epriestley.com>Apr 1 2013, 21:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1fd063277b0e: Move first-thread selection to the client in Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH787cc1dd8284: Make id/phid Conpherence stuff more consistent (authored by epriestley <git@epriestley.com>).Apr 1 2013, 21:44