Homec4science

Split Herald rule creation across several steps

Authored by epriestley <git@epriestley.com> on Dec 27 2013, 22:16.

Description

Split Herald rule creation across several steps

Summary:
Ref T4264. Currently, you choose a rule's content type (revision, commit, hook) and rule type (global, personal) on the same screen.

  • I want to make some rule types unavailable for some content types (e.g., personal hooks make little sense).
  • I want to make content type selection use a radio control instead of a dropdown, so it can explain what the content types do in more detail.
  • For new "object" hooks, I want to add a third step where you'll pick an object to bind to.

Split rule creation out into two steps. I think this won't get complicated enough for PHUIPagedFormView, but maybe I'll swap it in if this gets messier than I think.

Test Plan: Created some Herald rules, used back/cancel/etc.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4264

Differential Revision: https://secure.phabricator.com/D7845

Details

Committed
epriestley <git@epriestley.com>Dec 27 2013, 22:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce632d64906b: Use `ancestors(x)` instead of `0::x` in Mercurial history queries
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH79f57cf5171d: Split Herald rule creation across several steps (authored by epriestley <git@epriestley.com>).Dec 27 2013, 22:16