Homec4science

Add a "list<regex>" config option and move regex config to it

Authored by epriestley <git@epriestley.com> on Sep 13 2013, 20:48.

Description

Add a "list<regex>" config option and move regex config to it

Summary:
Fixes T3807. Several issues:

  • Currently, we split config of type list<string> on commas, which makes it impossible to enter a regex with a comma in it.
    • Split on newlines only.
  • Some of the examples are confusing (provided in JSON instead of the format you actually have to enter them).
    • Show examples in the same format you should enter text.
  • We didn't validate regexps.
    • Introduce list<regex> to validate regexes.

@hlau: Note that the old config format for the bugtraq stuff implied the delimiters on the regular expression. They are no longer implied. The examples show the correct format.

Test Plan: Viewed and edited affected config, hitting error and success cases.

Reviewers: btrahan

Reviewed By: btrahan

CC: hlau, aran

Maniphest Tasks: T3807

Differential Revision: https://secure.phabricator.com/D6969

Details

Committed
epriestley <git@epriestley.com>Sep 13 2013, 20:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPHea0dc5625d8f: Purge loadRelativeEdges
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7a39ac43b48c: Add a "list<regex>" config option and move regex config to it (authored by epriestley <git@epriestley.com>).Sep 13 2013, 20:48