Homec4science

Make file upload policies more consistent

Authored by epriestley <git@epriestley.com> on Mar 17 2015, 14:33.

Description

Make file upload policies more consistent

Summary:
Ref T7149. Currently, global drag and drop always uses the most open visibility policy on the install. This was appropriate before the application preference was introduced, but default to the application preference now.

In particular, this supports a default value of "Administrators" in the Phacility cluster.

Also simplify/clean up some code.

Test Plan:

  • Set application default policy to "Adminstrators".
  • Uploaded file via drag-and-drop, saw "administrators" policy.
  • Uploaded file via arc upload, saw "administrators" policy.
    • Saw better URI for a text file upload after patch.
  • Uploaded file via drag-and-drop-to-textarea, saw "only viewer" policy.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7149

Differential Revision: https://secure.phabricator.com/D12093

Details

Committed
epriestley <git@epriestley.com>Mar 17 2015, 14:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHca042df6deac: Minor change to suppress linter warning
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7a93b443c3d3: Make file upload policies more consistent (authored by epriestley <git@epriestley.com>).Mar 17 2015, 14:33