Homec4science

Improve error messages for PHABRICATOR_ENV

Authored by epriestley <git@epriestley.com> on May 31 2011, 04:52.

Description

Improve error messages for PHABRICATOR_ENV

Summary:

  • Allow user to specify "myconf" (recommended) or "myconf.conf.php" (less

surprising).

  • Make sure syntax errors and other problems are surfaced.
  • If the configuration value isn't valid, give them a list of all valid

values.

Test Plan:

  • Added a syntax error, got a useful error.
    • Set PHABRICATOR_ENV to a silly value, got a list of valid values.
    • Set PHABRICATOR_ENV to have .conf.php suffix, site still worked.

Reviewed By: kevinwallace
Reviewers: kevinwallace, codeblock, aran, jungejason, tuomaspelkonen
CC: aran, epriestley, kevinwallace
Differential Revision: 381

Details

Committed
epriestley <git@epriestley.com>Jun 1 2011, 04:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH74a2953ffdba: Support "!unsubscribe" in Differential reply handler
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7aa35821201a: Improve error messages for PHABRICATOR_ENV (authored by epriestley <git@epriestley.com>).Jun 1 2011, 04:18