Homec4science

Add a dropdown menu for Differential view options

Authored by epriestley <git@epriestley.com> on Jan 5 2012, 01:52.

Description

Add a dropdown menu for Differential view options

Summary:
There are several open Differential tasks that are basically blocked on not
having reasonable places in the UI to put things. Replace the "View Standalone /
Raw" button with a "View Options" dropdown menu so we can shove things like
"Expand All", "Fold / Unfold File", and "View in Diffusion" in there.

This doesn't change any behavior, just puts the existing options in a menu.

Test Plan:

  • Toggled menu open by clicking button.
  • Clicked menu items.
  • Toggled menu closed by clicking button.
  • Toggled menu closed by clicking document.
  • Toggled menu closed by opening another menu.
  • Toggled menu closed by selecting an item.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T497, T309

Differential Revision: https://secure.phabricator.com/D1316

Details

Committed
epriestley <git@epriestley.com>Jan 5 2012, 21:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1c1fe96becb9: Add more keyboard navigation options for inline comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH7abdf3afe0a8: Add a dropdown menu for Differential view options (authored by epriestley <git@epriestley.com>).Jan 5 2012, 21:58